Re: [PATCH v2] pseries: don't override CONFIG_PPC_PSERIES_DEBUG

[Linas Vepstas]

On 14 October 2010 19:48, Nishanth Aravamudan <nacc@xxxxxxxxxx> wrote:
> eeh and pci_dlpar #undef DEBUG, but I think they were added before the
> ability to control this from Kconfig. It's really annoying to only get
> some of the debug messages from these files. Leave the lpar.c #undef
> alone as it produces so much output as to make the kernel unusable.
> Update the Kconfig text to indicate this particular quirk :)
>
> Signed-off-by: Nishanth Aravamudan <nacc@xxxxxxxxxx>

OK, ignore my last email.

Acked by: Linas Vepstas <linasvepstas@xxxxxxxxx>


> --- a/arch/powerpc/platforms/pseries/Kconfig
> +++ b/arch/powerpc/platforms/pseries/Kconfig
> @@ -47,6 +47,12 @@ config LPARCFG
> Âconfig PPC_PSERIES_DEBUG
> Â Â Â Âdepends on PPC_PSERIES && PPC_EARLY_DEBUG
> Â Â Â Âbool "Enable extra debug logging in platforms/pseries"
> + Â Â Â Âhelp
> + Â Â Â Â Say Y here if you want the pseries core to produce a bunch of
> + Â Â Â Â debug messages to the system log. Select this if you are having a
> + Â Â Â Â problem with the pseries core and want to see more of what is
> + Â Â Â Â going on. This does not enable debugging in lpar.c, which must
> + Â Â Â Â be manually done due to its verbosity.
> Â Â Â Âdefault y

Umm, I see "default y" and you are not changing this but ... default y
?? Really?

Also, I am guessing that the lpar spam is due only to a handful of printk's,
while most of the rest will be infrequent.  Just knock out the
high-frequency ones...

--linas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/