Re: [PATCH 18/18] fs: do not assign default i_ino in new_inode

From: Nick Piggin
Date: Sat Oct 16 2010 - 03:57:45 EST


On Wed, Oct 13, 2010 at 11:16:01AM +1100, Dave Chinner wrote:
> From: Christoph Hellwig <hch@xxxxxx>
>
> Instead of always assigning an increasing inode number in new_inode
> move the call to assign it into those callers that actually need it.
> For now callers that need it is estimated conservatively, that is
> the call is added to all filesystems that do not assign an i_ino
> by themselves. For a few more filesystems we can avoid assigning
> any inode number given that they aren't user visible, and for others
> it could be done lazily when an inode number is actually needed,
> but that's left for later patches.

My patch for this reduces churn by just adding a new function instead.
The last_ino allocator is really fast now, so IMO it was not worth
the churn to go through filesystems; just let them do it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/