Re: [PATCH 02/05] Drivers: char: impi: Makefile: replace the useof <module>-objs with <module>-y

[Jiri Slaby]

On 10/16/2010 06:52 PM, Jiri Slaby wrote:
> On 10/16/2010 03:26 PM, Tracey Dent wrote:
>> Changed <module>-objs to <module>-y in Makefile.
>>
>> Signed-off-by: Tracey Dent <tdent48227@xxxxxxxxx>
>> ---
>>  drivers/char/ipmi/Makefile |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/char/ipmi/Makefile b/drivers/char/ipmi/Makefile
>> index eb8a1a8..16a9364 100644
>> --- a/drivers/char/ipmi/Makefile
>> +++ b/drivers/char/ipmi/Makefile
>> @@ -2,7 +2,7 @@
>>  # Makefile for the ipmi drivers.
>>  #
>>  
>> -ipmi_si-objs := ipmi_si_intf.o ipmi_kcs_sm.o ipmi_smic_sm.o ipmi_bt_sm.o
>> +ipmi_si-y := ipmi_si_intf.o ipmi_kcs_sm.o ipmi_smic_sm.o ipmi_bt_sm.o
> 
> NACK (and all of these). This will try to build 4 modules instead of
> one. Read Documentation/kbuild/makefiles.txt

Please disregard my NACK, I misread the patch.

regards,
-- 
js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/