Re: [PATCH] ath9k: Convert to new PCI PM framework
From: Rafael J. Wysocki
Date: Sat Oct 16 2010 - 16:04:03 EST
On Saturday, October 16, 2010, Luis R. Rodriguez wrote:
> On Fri, Oct 15, 2010 at 3:36 PM, Rafael J. Wysocki <rjw@xxxxxxx> wrote:
> > From: Rafael J. Wysocki <rjw@xxxxxxx>
> >
> > The ath9k driver uses the legacy PCI power management (suspend
> > and resume) callbacks that apparently cause intermittent problems
> > to happen (the adapter sometimes doesn't resume correctly on my
> > Acer Ferrari One). Make it use the new PCI PM and let the PCI core
> > code handle the PCI-specific details of power transitions.
> >
> > Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx>
>
> Do you know when these hooks were added?
Well, which ones? If you're asking about the new framework, it's been there
since 2.6.29 and is a recommended way of implementing PM hooks now.
Please have a look at Documentation/power/pci.txt. :-)
> If it fixes an issue should this go for stable?
I'm not 100% sure it fixes everything yet, although I hasn't been able to
reproduce the problem with it applied, so far.
So, I don't think it's -stable material at this point. However, it should be
done anyway at one point, so it very well can be done right now, given that I
have the hardware to test it. :-)
Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/