Re: [PATCH 17/19] fs: Reduce inode I_FREEING and factor inodedisposal

[Nick Piggin]

On Sat, Oct 16, 2010 at 09:30:47PM -0400, Christoph Hellwig wrote:
> >   * inode->i_lock is *always* the innermost lock.
> >   *
> > + * inode->i_lock is *always* the innermost lock.
> > + *
> 
> No need to repeat, we got it..

Except that I didn't see where you fixed all the places where it is
*not* the innermost lock. Like for example places that take dcache_lock
inside i_lock.

Really, the assertions that my series is causing the world to end
because it makes i_lock no longer the innermost lock (not that it is
anyway) etc. is just not constructive in the slightest.

A lock is a lock. If we take another lock inside it, it is not an
innermost lock. If we do it properly and don't introduce deadlocks, it
is not a bug.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/