Re: [PATCH] ACPI / Battery: Return -ENODATA for unknown values inget_property() (was: Re: Returning ACPI_BATTERY ...)

[Henrique de Moraes Holschuh]

On Sun, 17 Oct 2010, Rafael J. Wysocki wrote:
> In fact, the driver is supposed to return -ENODATA in that case, which will
> result in the read from /sys/class/power_supply/BAT0/current_now fail (I guess
> upower should be able to cope with that).

ENODATA?  Shouldn't it be ENXIO?  There is no non-blocking data stream
involved in a sysfs attribute.

Of course, the RIGHT thing would be to not expose in sysfs attributes
that are unsupported by the firmware/hardware in the first place, but
that's easier said than done.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/