Re: [PATCH] checkpatch: allow single space before labels

[Joe Perches]

On Sun, 2010-10-17 at 04:05 -0400, Mike Frysinger wrote:
> Signed-off-by: Mike Frysinger <vapier@xxxxxxxxxx>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
>  # check for spaces at the beginning of a line.
> -		if ($rawline =~ /^\+ / && $rawline !~ /\+ +\*/)  {
> +		if ($rawline =~ /^\+ / && $rawline !~ /\+ +\*/ && $rawline !~ /:$/)  {

Perhaps that's not an ideal test.
Maybe "&& $rawline !~ /^\+ \w+:/" is better.

The current test misidentify labels with comments:
drivers/net/tulip/interrupt.c: oom:    /* Executed with RX ints disabled */


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/