Re: [PATCH v7 03/12] Retry fault before vmentry

From: Avi Kivity
Date: Sun Oct 17 2010 - 06:45:07 EST


On 10/17/2010 12:33 PM, Avi Kivity wrote:
On 10/14/2010 11:22 AM, Gleb Natapov wrote:
When page is swapped in it is mapped into guest memory only after guest
tries to access it again and generate another fault. To save this fault
we can map it immediately since we know that guest is going to access
the page. Do it only when tdp is enabled for now. Shadow paging case is
more complicated. CR[034] and EFER registers should be switched before
doing mapping and then switched back.

+void kvm_arch_async_page_ready(struct kvm_vcpu *vcpu, struct kvm_async_pf *work)
+{
+ if (!vcpu->arch.mmu.direct_map || is_error_page(work->page))
+ return;
+ vcpu->arch.mmu.page_fault(vcpu, work->gva, 0, true);
+}

Missing mmu_topup_memory_caches().


Actually not. tdp_page_fault() has its own topup.


--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/