Re: [PATCH] ad525x_dpot: default to off

From: Randy Dunlap
Date: Sun Oct 17 2010 - 15:20:00 EST


On Sun, 17 Oct 2010 02:22:25 -0400 Mike Frysinger wrote:

> From: Michael Hennerich <michael.hennerich@xxxxxxxxxx>
>
> No reason for this to be enabled by default.

The default is automatically 'n', so please explain (more) why this is
needed...?

>
> Signed-off-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx>
> Signed-off-by: Mike Frysinger <vapier@xxxxxxxxxx>
> ---
> drivers/misc/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index b743312..7691f89 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -16,6 +16,7 @@ if MISC_DEVICES
> config AD525X_DPOT
> tristate "Analog Devices Digital Potentiometers"
> depends on (I2C || SPI) && SYSFS
> + default n
> help
> If you say yes here, you get support for the Analog Devices
> AD5258, AD5259, AD5251, AD5252, AD5253, AD5254, AD5255
> --

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/