Re: [PATCH] bluetooth: fix unaligned access to l2cap conf data

[Mike Frysinger]

On Mon, Oct 18, 2010 at 12:32, Gustavo F. Padovan wrote:
> * Harvey Harrison <harvey.harrison@xxxxxxxxx> [2010-10-18 11:17:28 -0700]:
>> On Sat, Oct 16, 2010 at 3:29 PM, Mike Frysinger <vapier@xxxxxxxxxx> wrote:
>> > From: steven miao <realmz6@xxxxxxxxx>
>> >
>> > Â Â Â Âcase 2:
>> > - Â Â Â Â Â Â Â *((__le16 *) opt->val) = cpu_to_le16(val);
>> > + Â Â Â Â Â Â Â put_unaligned_le16(cpu_to_le16(val), opt->val);
>> > Â Â Â Â Â Â Â Âbreak;
>>
>> I think you wanted:
>> put_unaligned_le16(val, opt->val);
>
> I fixed that in the tree. Thanks for the report.

i guess you fixed the 32bit one too ?
  put_unaligned_le32(cpu_to_le32(val), opt->val);
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/