RE: [PATCH 4/9] ARM: S3C64XX: add USB host support for mach-real6410

[Kukjin Kim]

Darius Augulis wrote:
> 
> On Mon, Oct 18, 2010 at 4:39 PM, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote:
> > Darius Augulis wrote:
> >>
> >> Add USB host device support for mach-real6410
> >>
> >> Signed-off-by: Darius Augulis <augulis.darius@xxxxxxxxx>
> >> ---
> >>  arch/arm/mach-s3c64xx/Kconfig         |    1 +
> >>  arch/arm/mach-s3c64xx/mach-real6410.c |    1 +
> >>  2 files changed, 2 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/arch/arm/mach-s3c64xx/Kconfig
b/arch/arm/mach-s3c64xx/Kconfig
> >> index b706b80..c05ae12 100644
> >> --- a/arch/arm/mach-s3c64xx/Kconfig
> >> +++ b/arch/arm/mach-s3c64xx/Kconfig
> >> @@ -109,6 +109,7 @@ config MACH_REAL6410
> >>       select S3C_DEV_NAND
> >>       select SAMSUNG_DEV_ADC
> >>       select SAMSUNG_DEV_TS
> >> +     select S3C_DEV_USB_HOST
> >>       help
> >>         Machine support for the CoreWind REAL6410
> >>
> >> diff --git a/arch/arm/mach-s3c64xx/mach-real6410.c b/arch/arm/mach-
> >> s3c64xx/mach-real6410.c
> >> index bad6990..00e7d7e 100644
> >> --- a/arch/arm/mach-s3c64xx/mach-real6410.c
> >> +++ b/arch/arm/mach-s3c64xx/mach-real6410.c
> >> @@ -195,6 +195,7 @@ static struct platform_device *real6410_devices[]
> >> __initdata = {
> >>       &s3c_device_nand,
> >>       &s3c_device_adc,
> >>       &s3c_device_ts,
> >> +     &s3c_device_ohci,
> >>  };
> >>
> >>  static struct s3c2410_ts_mach_info s3c_ts_platform __initdata = {
> >
> > No need any gpio configuration for it?
> 
> No, USB is powered by hardware at startup and does not need any other
> gpio config.
> 

Hmm...firstly see below...

+-----+        +------ UTMI -------- OTG Device
| PHY |--------|
+-----+        +--- Serial I/F 1 --- Host 1.1 (1port)

+---------------+
|USB Transceiver|-- Serial I/F 2 --- Host 1.1 (1port)
+---------------+

If you want to use only 1port Host 1.1 through Serial I/F2, your code is ok.
but want to use 2-port Host 1.1, need to set configuration of PHY
initialization and clock path for Serial I/F1.
I meant that.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/