Re: [PATCH 1/3] usb: fix Kconfig warning

[Felipe Balbi]

On Tue, Oct 19, 2010 at 03:04:24AM -0500, Felipe Contreras wrote:
> warning: (USB_MUSB_HDRC_HCD && USB_SUPPORT && USB_MUSB_HDRC &&
> (USB_MUSB_HOST || USB_MUSB_OTG) && USB_GADGET_MUSB_HDRC || USB_MUSB_OTG
> && <choice> && USB && USB_GADGET && PM && EXPERIMENTAL) selects USB_OTG
> which has unmet direct dependencies (USB_GADGET_OMAP && ARCH_OMAP_OTG &&
> USB_OHCI_HCD)
>
> This doesn't seem to happen on 2.6.36-rc8, but still doesn't make sense
> to keep this useless config.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@xxxxxxxxx>
> ---
> drivers/usb/gadget/Kconfig |   11 -----------
> 1 files changed, 0 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index cd27f9b..19a6eb6 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -209,17 +209,6 @@ config USB_OMAP
> 	default USB_GADGET
> 	select USB_GADGET_SELECTED
>
> -config USB_OTG
> -	boolean "OTG Support"
> -	depends on USB_GADGET_OMAP && ARCH_OMAP_OTG && USB_OHCI_HCD
> -	help
> -	   The most notable feature of USB OTG is support for a
> -	   "Dual-Role" device, which can act as either a device
> -	   or a host.  The initial role choice can be changed
> -	   later, when two dual-role devices talk to each other.
> -
> -	   Select this only if your OMAP board has a Mini-AB connector.
> -

ok since this is replicated on drivers/usb/core/Kconfig but it's not
reflected on changelog. Could you add some extra comment ?

--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/