Re: [PATCH 3/3] drivers: cleanup Kconfig stuff

[Felipe Balbi]

Hi,

On Tue, Oct 19, 2010 at 03:34:55AM -0500, Felipe Contreras wrote:
> > It was fine as it was before. NAK
>
> It's not fine. You can build with CONFIG_USB_G_NOKIA=y, and it doesn't
> work. Definitely some dependency is missing.

if phonet is not set it should not build. If phonet is set to module and
g_nokia to built-in, then it's your mistake.

> How do you handle USB_MUSB_HDRC=y and NOP_USB_XCEIV=n and TWL4030_USB=n?
>
> depends on (NOP_USB_XCEIV || TWL4030_USB) ?

you're selecting, not depending on this patch. What I mean is that you
will enable a useless driver on some boards if you "select TWL4030_USB
if ARCH_OMAP3"

--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/