Re: [PATCH 3/3] drivers: cleanup Kconfig stuff

From: Felipe Balbi
Date: Tue Oct 19 2010 - 06:13:20 EST


Hi,

On Tue, Oct 19, 2010 at 04:55:04AM -0500, Felipe Contreras wrote:
I'm not talking about phonet, I replied to your comment regarding
USB_GADGET_MUSB_HDRC. For me USB_GADGET_MUSB_HDRC=n USB_G_NOKIA=y
doesn't work, but the Kconfig allows it.

I see, that's a problem for sure.

Ok, I'll make it: depends on (NOP_USB_XCEIV || TWL4030_USB)

BTW, if you want to try this:
./scripts/kconfig/conf --defconfig=usb_defconfig arch/arm/Kconfig

usb_defconfig:
CONFIG_ARCH_OMAP=y
CONFIG_EXPERIMENTAL=y
CONFIG_NET=y
CONFIG_PHONET=y

CONFIG_USB=y
CONFIG_USB_GADGET=y
CONFIG_USB_MUSB_OTG=y
CONFIG_USB_MUSB_HDRC=y
CONFIG_USB_G_NOKIA=y

# TODO USB_MUSB_OTG should select this
CONFIG_USB_GADGET_MUSB_HDRC=y

I expect TWL4030_USB and USB_OTG to be automatically selected.

could be, but that's a board-by-board thing. It's not mandatory to have
twl4030-usb, it's mandatory to have a transceiver, not matter which one
it is.

--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/