Re: [PATCH v2 3/3] drivers: cleanup Kconfig stuff

From: Felipe Balbi
Date: Tue Oct 19 2010 - 07:53:00 EST


Hi,

On Tue, Oct 19, 2010 at 06:36:32AM -0500, Felipe Contreras wrote:
That is actually the intention.

so it's a bit messed up one :-p

It's the other way around. He wanted to get rid of defconfigs
completely by moving the complexity to Kconfigs:

Yes, but he was suggesting to add things like Kconfig.rx51 and that
would be selecting correct drivers to get rx51 working, he was
definitely not suggesting to add sensible defaults all over the tree.

http://article.gmane.org/gmane.linux.kernel/994720
http://article.gmane.org/gmane.linux.kernel/994706
http://article.gmane.org/gmane.linux.kernel/994718

You seem to be pushing for the exact opposite; keep the complexity on
the defconfigs and the burden on the user creating configs.

no, you got me wrong. We do need to get rid of defconfigs, but we have
to do so while keeping the resulting binary working and as of today, if
you enable more than one transceiver driver, it won't work.

Ok. But for now 'default y if ARCH_OMAP3' for TWL4030_USB doesn't
hurt, nor increases the total size of Kconfigs, and solves a real
problem.

I don't see it that way. I see that there will be boards with one too
many transceivers enabled and the resulting binary won't work, but I'll
leave that for Greg to decide.

--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/