Re: [PATCH 1/3] staging: batman-adv: remove uselessaddr_to_string()

[Greg KH]

On Sat, Oct 16, 2010 at 01:11:10PM +0300, Andy Shevchenko wrote:
> Since all *printf() methods in the kernel understand '%pM' modifier the
> conversion to the string is useless beforehand.
> 
> Additionally this patch decreases batman_if structure by 20 bytes.

And also, it breaks the build:
	drivers/staging/batman-adv/vis.c: In function âvis_data_read_entryâ:
	drivers/staging/batman-adv/vis.c:170:38: error: âtoâ undeclared (first use in this function)
	drivers/staging/batman-adv/vis.c:170:38: note: each undeclared identifier is reported only once for each function it appears in

Please always test your patches :(

I've dropped this one.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/