Re: [patch]x86: spread tlb flush vector between nodes

From: Shaohua Li
Date: Tue Oct 19 2010 - 21:13:46 EST


On Tue, 2010-10-19 at 21:34 +0800, Andi Kleen wrote:
> >
> > +static int tlb_vector_offset[NR_CPUS] __read_mostly;
>
> Never use NR_CPUS. Always use per cpu data.
>
> Otherwise you waste a lot of space on a CONFIG_MAX_SMP
> kernel running on a smaller box.
ha, I want it to be __read_mostly to avoid cache pollution, apparently
we have no per cpu API to do this. Maybe I need add one.

Thanks,
Shaohua

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/