Re: [resend][PATCH 2/2] mm, mem-hotplug: update pcp->stat_thresholdwhen memory hotplug occur

[Andrew Morton]

On Wed, 20 Oct 2010 11:07:33 +0900 (JST) KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> wrote:

> > > > @@ -5013,6 +5014,8 @@ int __meminit init_per_zone_wmark_min(void)
> > > >  		min_free_kbytes = 128;
> > > >  	if (min_free_kbytes > 65536)
> > > >  		min_free_kbytes = 65536;
> > > > +
> > > > +	refresh_zone_stat_thresholds();
> > > >  	setup_per_zone_wmarks();
> > > >  	setup_per_zone_lowmem_reserve();
> > > >  	setup_per_zone_inactive_ratio();
> > > 
> > > setup_per_zone_wmarks() could change the min and low watermarks for a zone 
> > > when refresh_zone_stat_thresholds() would have used the old value.
> > 
> > Indeed.
> > 
> > I could make the obvious fix, but then what I'd have wouldn't be
> > sufficiently tested.
> 
> Can we review this?

It's unclear what you mean?

The patches otherwise look OK to me, but it's pretty easy to make
mistakes in this area.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/