Re: [patch 26/35] fs: icache alloc anonymous inode allocation

From: Nick Piggin
Date: Tue Oct 19 2010 - 22:38:36 EST


On Tue, Oct 19, 2010 at 05:50:00PM +0200, Miklos Szeredi wrote:
> On Tue, 19 Oct 2010, npiggin@xxxxxxxx wrote:
> > Index: linux-2.6/fs/anon_inodes.c
> > ===================================================================
> > --- linux-2.6.orig/fs/anon_inodes.c 2010-10-19 14:18:58.000000000 +1100
> > +++ linux-2.6/fs/anon_inodes.c 2010-10-19 14:19:19.000000000 +1100
> > @@ -191,7 +191,7 @@
> > */
> > static struct inode *anon_inode_mkinode(void)
> > {
> > - struct inode *inode = new_inode(anon_inode_mnt->mnt_sb);
> > + struct inode *inode = new_anon_inode(anon_inode_mnt->mnt_sb);
> >
> > if (!inode)
> > return ERR_PTR(-ENOMEM);
>
> This too needs an inode->i_ino initialization (the default ULONG_MAX
> will cause EOVERFLOW on 32bit fstat, AFAIK), though it could just be a
> constant, say 2.

OK. I'll add a #define for it. Thanks

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/