RE: [PATCHv4 4/4] iommu: create new api to set valid da range

[Guzman Lugo, Fernando]

> -----Original Message-----
> From: Hiroshi DOYU [mailto:Hiroshi.DOYU@xxxxxxxxx] 
> Sent: Wednesday, October 20, 2010 4:27 AM
> To: felipe.contreras@xxxxxxxxx
> Cc: Guzman Lugo, Fernando; felipe.contreras@xxxxxxxxx; 
> david.cohen@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; 
> linux-omap@xxxxxxxxxxxxxxx
> Subject: Re: [PATCHv4 4/4] iommu: create new api to set valid da range
> 
> From: ext Felipe Contreras <felipe.contreras@xxxxxxxxx>
> Subject: Re: [PATCHv4 4/4] iommu: create new api to set valid da range
> Date: Wed, 20 Oct 2010 10:58:16 +0200
> 
> > On Wed, Oct 20, 2010 at 11:45 AM, Hiroshi DOYU 
> <Hiroshi.DOYU@xxxxxxxxx> wrote:
> >> From: "ext felipe.contreras@xxxxxxxxx" <felipe.contreras@xxxxxxxxx>
> >> Subject: Re: [PATCHv4 4/4] iommu: create new api to set valid da 
> >> range
> >> Date: Wed, 20 Oct 2010 10:35:50 +0200
> >>
> >>> On Wed, Oct 20, 2010 at 5:48 AM, Fernando Guzman Lugo 
> <x0095840@xxxxxx> wrote:
> >>>> Some IOMMUs cannot use the whole 0x0 - 0xFFFFFFFF range.
> >>>> With this new API the valid range can be set.
> >>>>
> >>>> Signed-off-by: Fernando Guzman Lugo <x0095840@xxxxxx>
> >>>
> >>> I don't see the point in having an API. It could be done through 
> >>> platform data, and the usage of 0xFFFFF000 instead of 
> ULONG_MAX is 
> >>> independent of this.
> >>
> >> Using platform data is better, but why dropping da_end?
> > 
> > Because it's always 0xFFFFF000. Do you know of any instance 
> where it's 
> >not?
> 
> We should try to avoid forcing unnecessary limitations and 
> dependencies. The usage of device virtual address space range 
> depends on dsp(coprocessor) side S/W implimentation or configuration.

I am agree. The valid range depends on the user (dsp or something else)
The only limitation of see in the iommu is that range has to be
Page aligned and that should be the only limitation.

Regards,
Fernando.

> --
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/