Re: [PATCH 4/6] usb: Add support for VIA VT8500 and compatibles inEHCI HCD

[Alexey Charkov]

2010/10/21 Greg KH <gregkh@xxxxxxx>:
> On Thu, Oct 21, 2010 at 02:41:54AM +0400, Alexey Charkov wrote:
>> 2010/10/21 Greg KH <gregkh@xxxxxxx>:
>> > On Thu, Oct 21, 2010 at 12:55:36AM +0400, Alexey Charkov wrote:
>> >> VIA and WonderMedia Systems-on-Chip feature a standard EHCI host
>> >> controller. This adds necessary glue to use the standard driver
>> >> with these systems.
>> >>
>> >> Signed-off-by: Alexey Charkov <alchark@xxxxxxxxx>
>> >> ---
>> >>
>> >> Please review and state whether this could be acceptable for a merge
>> >> to mainline in the coming 2.6.37 window. If possible, I would deeply
>> >> appreciate a merge to a relevant git tree for integration prior to
>> >> asking Linus to pull the changes. I could rebase the code if needed,
>> >> currently this is against Linus' master branch.
>> >>
>> >> This patch relies on the basic architecture support for VT8500/WM8505
>> >> to be in place, as introduced by PATCH 1/6 in this series.
>> >
>> > Will this code fail to build without that patch?
>> >
>>
>> As all the additions are ifdef-ed, it won't unless somebody manually
>> defines CONFIG_ARCH_VT8500. But in that case the person should
>> probably know what (s)he is doing.
>
> Ok, how about we wait for the core code to be accepted, and then have
> you resend the drivers for submission?
>
> Make sense?
>

For me, it's perfectly fine. I was just a bit uncomfortable about
submitting the core code with platform data for missing drivers, which
take quite a sizeable part of that PATCH 1/6.

> thanks,
>
> greg k-h
>

Best regards,
Alexey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/