Re: [PATCH 5/5] x86: OLPC: add OLPC device-tree support

From: Andres Salomon
Date: Thu Oct 21 2010 - 17:18:03 EST

Next message: Joe Perches: "Re: [PATCH v3 10/12] backlight: add support for tps6116x controller"
Previous message: Micha Nelissen: "Re: [PATCH -mm 0/2] RapidIO: Changes to handling of RIO switches"
In reply to: Grant Likely: "Re: [PATCH 5/5] x86: OLPC: add OLPC device-tree support"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Wed, 20 Oct 2010 12:56:21 -0600
Grant Likely <grant.likely@xxxxxxxxxxxx> wrote:

> On Sun, Oct 10, 2010 at 10:13 PM, Grant Likely
> <grant.likely@xxxxxxxxxxxx> wrote:
> > On Sun, Oct 10, 2010 at 02:06:26AM -0700, Andres Salomon wrote:
> >>
> >> Make use of PROC_DEVICETREE to export the tree, and sparc's
> >> PROMTREE code to call into OLPC's Open Firmware to build the tree.
> >>
> >> Signed-off-by: Andres Salomon <dilinger@xxxxxxxxxx>
> >
> > Holding off on this one until I hear from the x86 maintainers
> > [cc'd].
>
> Oops, and it appears that patch breaks the build on other
> architectures when CONFIG_OF is enabled and CONFIG_PROMTREE is not due
> to how of_pdt_init_devicetree is defined.
>
> g.
>

D'oh. Do you have any preferences for what we should be using here?
Generic OF hook? PDT-specific hook? Forget the hook and just call
a PDT function? I'm leaning towards that last option.

> >
> > g.
> >
> >> ---
> >> Âarch/x86/Kconfig Â Â Â Â Â Â Â Â| Â Â2 +
> >> Âarch/x86/include/asm/olpc_ofw.h | Â Â4 +
> >> Âarch/x86/include/asm/prom.h Â Â | Â Â1 +
> >> Âarch/x86/kernel/Makefile Â Â Â Â| Â Â1 +
> >> Âarch/x86/kernel/olpc_ofw.c Â Â Â| Â Â8 ++
> >> Âarch/x86/kernel/olpc_prom.c Â Â | Â152
> >> +++++++++++++++++++++++++++++++++++++++ drivers/of/pdt.c
> >> Â Â Â| Â Â2 + fs/proc/proc_devtree.c Â Â Â Â Â| Â Â4 +
> >> Âinclude/linux/of_pdt.h Â Â Â Â Â| Â Â1 +
> >> Â9 files changed, 175 insertions(+), 0 deletions(-)
> >> Âcreate mode 100644 arch/x86/include/asm/prom.h
> >> Âcreate mode 100644 arch/x86/kernel/olpc_prom.c
> >>
> >> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> >> index cea0cd9..7d4ef72 100644
> >> --- a/arch/x86/Kconfig
> >> +++ b/arch/x86/Kconfig
> >> @@ -2069,6 +2069,8 @@ config OLPC_OPENFIRMWARE
> >> Â Â Â bool "Support for OLPC's Open Firmware"
> >> Â Â Â depends on !X86_64 && !X86_PAE
> >> Â Â Â default y if OLPC
> >> + Â Â select OF
> >> + Â Â select OF_PROMTREE
> >> Â Â Â help
> >> Â Â Â Â This option adds support for the implementation of Open
> >> Firmware that is used on the OLPC XO-1 Children's Machine.
> >> diff --git a/arch/x86/include/asm/olpc_ofw.h
> >> b/arch/x86/include/asm/olpc_ofw.h index 08fde47..13075df 100644
> >> --- a/arch/x86/include/asm/olpc_ofw.h
> >> +++ b/arch/x86/include/asm/olpc_ofw.h
> >> @@ -28,4 +28,8 @@ static inline void setup_olpc_ofw_pgd(void) { }
> >>
> >> Â#endif /* !CONFIG_OLPC_OPENFIRMWARE */
> >>
> >> +#ifdef CONFIG_PROC_DEVICETREE
> >> +extern void olpc_prom_build_devicetree(void);
> >> +#endif /* CONFIG_PROC_DEVICETREE */
> >> +
> >> Â#endif /* _ASM_X86_OLPC_OFW_H */
> >> diff --git a/arch/x86/include/asm/prom.h
> >> b/arch/x86/include/asm/prom.h new file mode 100644
> >> index 0000000..b4ec95f
> >> --- /dev/null
> >> +++ b/arch/x86/include/asm/prom.h
> >> @@ -0,0 +1 @@
> >> +/* dummy prom.h; here to make linux/of.h's #includes happy */
> >> diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile
> >> index fedf32a..ced0c9a 100644
> >> --- a/arch/x86/kernel/Makefile
> >> +++ b/arch/x86/kernel/Makefile
> >> @@ -107,6 +107,7 @@ scx200-y Â Â Â Â Â Â Â Â Â+= scx200_32.o
> >>
> >> Âobj-$(CONFIG_OLPC) Â Â Â Â Â += olpc.o
> >> Âobj-$(CONFIG_OLPC_OPENFIRMWARE) Â Â Â+= olpc_ofw.o
> >> +obj-$(CONFIG_PROC_DEVICETREE) Â Â Â Â+= olpc_prom.o
> >> Âobj-$(CONFIG_X86_MRST) Â Â Â Â Â Â Â += mrst.o
> >>
> >> Âmicrocode-y Â Â Â Â Â Â Â Â Â Â Â Â Â:= microcode_core.o
> >> diff --git a/arch/x86/kernel/olpc_ofw.c
> >> b/arch/x86/kernel/olpc_ofw.c index 3218aa7..6c4d243 100644
> >> --- a/arch/x86/kernel/olpc_ofw.c
> >> +++ b/arch/x86/kernel/olpc_ofw.c
> >> @@ -1,5 +1,7 @@
> >> Â#include <linux/kernel.h>
> >> Â#include <linux/module.h>
> >> +#include <linux/of.h>
> >> +#include <linux/of_pdt.h>
> >> Â#include <linux/init.h>
> >> Â#include <asm/page.h>
> >> Â#include <asm/setup.h>
> >> @@ -38,6 +40,12 @@ void __init setup_olpc_ofw_pgd(void)
> >> Â Â Â /* implicit optimization barrier here due to uninline
> >> function return */
> >>
> >> Â Â Â early_iounmap(base, sizeof(olpc_ofw_pgd) * PTRS_PER_PGD);
> >> +
> >> +#ifdef CONFIG_PROC_DEVICETREE
> >> + Â Â /* OFW set up succesfully; use it for the device tree */
> >> + Â Â of_pdt_init_devicetree = olpc_prom_build_devicetree;
> >> +#endif
> >> +
> >> Â}
> >>
> >> Âint __olpc_ofw(const char *name, int nr_args, const void **args,
> >> int nr_res, diff --git a/arch/x86/kernel/olpc_prom.c
> >> b/arch/x86/kernel/olpc_prom.c new file mode 100644
> >> index 0000000..e2ecaf2
> >> --- /dev/null
> >> +++ b/arch/x86/kernel/olpc_prom.c
> >> @@ -0,0 +1,152 @@
> >> +/*
> >> + * olpc_prom.c: OLPC-specific OFW device tree support code.
> >> + *
> >> + * Paul Mackerras Â ÂAugust 1996.
> >> + * Copyright (C) 1996-2005 Paul Mackerras.
> >> + *
> >> + * ÂAdapted for 64bit PowerPC by Dave Engebretsen and Peter
> >> Bergner.
> >> + * Â Â{engebret|bergner}@us.ibm.com
> >> + *
> >> + * ÂAdapted for sparc by David S. Miller davem@xxxxxxxxxxxxx
> >> + * ÂAdapted for x86/OLPC by Andres Salomon <dilinger@xxxxxxxxxx>
> >> + *
> >> + * Â Â ÂThis program is free software; you can redistribute it
> >> and/or
> >> + * Â Â Âmodify it under the terms of the GNU General Public
> >> License
> >> + * Â Â Âas published by the Free Software Foundation; either
> >> version
> >> + * Â Â Â2 of the License, or (at your option) any later version.
> >> + */
> >> +
> >> +#include <linux/kernel.h>
> >> +#include <linux/module.h>
> >> +#include <linux/errno.h>
> >> +#include <linux/slab.h>
> >> +#include <linux/of.h>
> >> +#include <linux/of_pdt.h>
> >> +#include <asm/olpc_ofw.h>
> >> +
> >> +static phandle __init olpc_prom_getsibling(phandle node)
> >> +{
> >> + Â Â const void *args[] = { (void *)node };
> >> + Â Â void *res[] = { &node };
> >> +
> >> + Â Â if (node == -1)
> >> + Â Â Â Â Â Â return 0;
> >> +
> >> + Â Â if (olpc_ofw("peer", args, res) || node == -1)
> >> + Â Â Â Â Â Â return 0;
> >> +
> >> + Â Â return node;
> >> +}
> >> +
> >> +static phandle __init olpc_prom_getchild(phandle node)
> >> +{
> >> + Â Â const void *args[] = { (void *)node };
> >> + Â Â void *res[] = { &node };
> >> +
> >> + Â Â if (node == -1)
> >> + Â Â Â Â Â Â return 0;
> >> +
> >> + Â Â if (olpc_ofw("child", args, res) || node == -1) {
> >> + Â Â Â Â Â Â pr_err("PROM: %s: fetching child failed!\n",
> >> __func__);
> >> + Â Â Â Â Â Â return 0;
> >> + Â Â }
> >> +
> >> + Â Â return node;
> >> +}
> >> +
> >> +static int __init olpc_prom_getproplen(phandle node, const char
> >> *prop) +{
> >> + Â Â const void *args[] = { (void *)node, prop };
> >> + Â Â int len;
> >> + Â Â void *res[] = { &len };
> >> +
> >> + Â Â if (node == -1)
> >> + Â Â Â Â Â Â return -1;
> >> +
> >> + Â Â if (olpc_ofw("getproplen", args, res)) {
> >> + Â Â Â Â Â Â pr_err("PROM: %s: getproplen failed!\n", __func__);
> >> + Â Â Â Â Â Â return -1;
> >> + Â Â }
> >> +
> >> + Â Â return len;
> >> +}
> >> +
> >> +static int __init olpc_prom_getproperty(phandle node, const char
> >> *prop,
> >> + Â Â Â Â Â Â char *buf, int bufsize)
> >> +{
> >> + Â Â int plen;
> >> +
> >> + Â Â plen = olpc_prom_getproplen(node, prop);
> >> + Â Â if (plen > bufsize || plen < 1)
> >> + Â Â Â Â Â Â return -1;
> >> + Â Â else {
> >> + Â Â Â Â Â Â const void *args[] = { (void *)node, prop, buf,
> >> (void *)plen };
> >> + Â Â Â Â Â Â void *res[] = { &plen };
> >> +
> >> + Â Â Â Â Â Â if (olpc_ofw("getprop", args, res)) {
> >> + Â Â Â Â Â Â Â Â Â Â pr_err("PROM: %s: getprop failed!\n",
> >> __func__);
> >> + Â Â Â Â Â Â Â Â Â Â return -1;
> >> + Â Â Â Â Â Â }
> >> + Â Â }
> >> +
> >> + Â Â return plen;
> >> +}
> >> +
> >> +static int __init olpc_prom_nextprop(phandle node, char *prev,
> >> char *buf) +{
> >> + Â Â const void *args[] = { (void *)node, prev, buf };
> >> + Â Â int success;
> >> + Â Â void *res[] = { &success };
> >> +
> >> + Â Â buf[0] = '\0';
> >> +
> >> + Â Â if (node == -1)
> >> + Â Â Â Â Â Â return -1;
> >> +
> >> + Â Â if (olpc_ofw("nextprop", args, res) || success != 1)
> >> + Â Â Â Â Â Â return -1;
> >> +
> >> + Â Â return 0;
> >> +}
> >> +
> >> +static int __init olpc_prom_pkg2path(phandle node, char *buf,
> >> + Â Â Â Â Â Â const int buflen, int *len)
> >> +{
> >> + Â Â const void *args[] = { (void *)node, buf, (void *)buflen };
> >> + Â Â void *res[] = { len };
> >> +
> >> + Â Â if (node == -1)
> >> + Â Â Â Â Â Â return -1;
> >> +
> >> + Â Â if (olpc_ofw("package-to-path", args, res) || *len < 1)
> >> + Â Â Â Â Â Â return -1;
> >> +
> >> + Â Â return 0;
> >> +}
> >> +
> >> +void * __init prom_early_alloc(unsigned long size)
> >> +{
> >> + Â Â /* this is called late enough that we can alloc normally */
> >> + Â Â return kzalloc(size, GFP_KERNEL);
> >> +}
> >> +
> >> +static struct of_pdt_ops prom_olpc_ops __initdata = {
> >> + Â Â .nextprop = olpc_prom_nextprop,
> >> + Â Â .getproplen = olpc_prom_getproplen,
> >> + Â Â .getproperty = olpc_prom_getproperty,
> >> + Â Â .getchild = olpc_prom_getchild,
> >> + Â Â .getsibling = olpc_prom_getsibling,
> >> + Â Â .pkg2path = olpc_prom_pkg2path,
> >> +};
> >> +
> >> +void __init olpc_prom_build_devicetree(void)
> >> +{
> >> + Â Â phandle root;
> >> +
> >> + Â Â root = olpc_prom_getsibling(0);
> >> + Â Â if (root < 0) {
> >> + Â Â Â Â Â Â pr_err("PROM: unable to get root node from OFW!\n");
> >> + Â Â Â Â Â Â return;
> >> + Â Â }
> >> + Â Â of_pdt_build_devicetree(root, &prom_olpc_ops);
> >> +}
> >> diff --git a/drivers/of/pdt.c b/drivers/of/pdt.c
> >> index 28295d0..07e3daa 100644
> >> --- a/drivers/of/pdt.c
> >> +++ b/drivers/of/pdt.c
> >> @@ -29,6 +29,8 @@ static struct of_pdt_ops *of_pdt_prom_ops
> >> __initdata; void __initdata (*of_pdt_build_more)(struct
> >> device_node *dp, struct device_node ***nextp);
> >>
> >> +void __initdata (*of_pdt_init_devicetree)(void);
> >> +
> >> Â#if defined(CONFIG_SPARC)
> >> Âunsigned int of_pdt_unique_id __initdata;
> >>
> >> diff --git a/fs/proc/proc_devtree.c b/fs/proc/proc_devtree.c
> >> index d9396a4..9779039 100644
> >> --- a/fs/proc/proc_devtree.c
> >> +++ b/fs/proc/proc_devtree.c
> >> @@ -11,6 +11,7 @@
> >> Â#include <linux/stat.h>
> >> Â#include <linux/string.h>
> >> Â#include <linux/of.h>
> >> +#include <linux/of_pdt.h>
> >> Â#include <linux/module.h>
> >> Â#include <linux/slab.h>
> >> Â#include <asm/prom.h>
> >> @@ -228,6 +229,9 @@ void __init proc_device_tree_init(void)
> >> Â{
> >> Â Â Â struct device_node *root;
> >>
> >> + Â Â if (of_pdt_init_devicetree)
> >> + Â Â Â Â Â Â of_pdt_init_devicetree();
> >> +
> >> Â Â Â proc_device_tree = proc_mkdir("device-tree", NULL);
> >> Â Â Â if (proc_device_tree == NULL)
> >> Â Â Â Â Â Â Â return;
> >> diff --git a/include/linux/of_pdt.h b/include/linux/of_pdt.h
> >> index c65a18a..5b29aef 100644
> >> --- a/include/linux/of_pdt.h
> >> +++ b/include/linux/of_pdt.h
> >> @@ -38,6 +38,7 @@ extern void *prom_early_alloc(unsigned long
> >> size);
> >>
> >> Â/* for building the device tree */
> >> Âextern void of_pdt_build_devicetree(phandle root_node, struct
> >> of_pdt_ops *ops); +extern void (*of_pdt_init_devicetree)(void);
> >>
> >> Âextern void (*of_pdt_build_more)(struct device_node *dp,
> >> Â Â Â Â Â Â Â struct device_node ***nextp);
> >> --
> >> 1.5.6.5
> >>
> >
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Joe Perches: "Re: [PATCH v3 10/12] backlight: add support for tps6116x controller"
Previous message: Micha Nelissen: "Re: [PATCH -mm 0/2] RapidIO: Changes to handling of RIO switches"
In reply to: Grant Likely: "Re: [PATCH 5/5] x86: OLPC: add OLPC device-tree support"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]