[tip:x86/debug] x86, asm: Fix ancient-GAS workaround

From: tip-bot for Alexander van Heukelum
Date: Fri Oct 22 2010 - 05:56:43 EST


Commit-ID: a22dcdb0032c78c6b443f6897d7ac432a3b5a272
Gitweb: http://git.kernel.org/tip/a22dcdb0032c78c6b443f6897d7ac432a3b5a272
Author: Alexander van Heukelum <heukelum@xxxxxxxxxxx>
AuthorDate: Thu, 21 Oct 2010 23:30:49 +0200
Committer: Ingo Molnar <mingo@xxxxxxx>
CommitDate: Fri, 22 Oct 2010 10:45:02 +0200

x86, asm: Fix ancient-GAS workaround

It turns out to generate something like this:

printk ( ("<3>") "something");

The extra parentheses here break the UML compile.

Change the sed-program to add the parentheses only for numbers.

Reported-by: Ingo Molnar <mingo@xxxxxxx>
Signed-off-by: Alexander van Heukelum <heukelum@xxxxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxxxx>
LKML-Reference: <1287696649.20421.1401306095@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
---
Kbuild | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/Kbuild b/Kbuild
index 3995939..431f7ca 100644
--- a/Kbuild
+++ b/Kbuild
@@ -53,7 +53,8 @@ targets += arch/$(SRCARCH)/kernel/asm-offsets.s
# Default sed regexp - multiline due to syntax constraints
define sed-y
"/^->/{s:->#\(.*\):/* \1 */:; \
- s:^->\([^ ]*\) [\$$#]*\([^ ]*\) \(.*\):#define \1 (\2) /* \3 */:; \
+ s:^->\([^ ]*\) [\$$#]*\([-0-9]*\) \(.*\):#define \1 (\2) /* \3 */:; \
+ s:^->\([^ ]*\) [\$$#]*\([^ ]*\) \(.*\):#define \1 \2 /* \3 */:; \
s:->::; p;}"
endef

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/