Re: [PATCH v3 01/12] misc: add driver for sequencer serial port

[Cyril Chemparathy]

On 10/21/2010 07:12 PM, Andrew Morton wrote:
>
> ...
>
>> +/* Register Access Helpers */
>> +static inline u32 ssp_read(struct ti_ssp *ssp, int reg)
>> +{
>> +	return __raw_readl(ssp->regs + reg);
>> +}
>> +
>> +static inline void ssp_write(struct ti_ssp *ssp, int reg, u32 val)
>> +{
>> +	__raw_writel(val, ssp->regs + reg);
>> +}
> 
> Why are the __raw functions used here?
> 

These registers are to be accessed native endian at all times, and
therefore the le32 conversion done otherwise is inappropriate.

Thanks for the feedback.  I will post an updated series with these changes.

Regards
Cyril.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/