Re: [PATCH v3 01/12] misc: add driver for sequencer serial port

From: Cyril Chemparathy
Date: Fri Oct 22 2010 - 15:04:38 EST


On 10/22/2010 10:20 AM, Alan Cox wrote:
> On Thu, 21 Oct 2010 17:01:02 -0400
> Cyril Chemparathy <cyril@xxxxxx> wrote:
>
>> TI's sequencer serial port (TI-SSP) is a jack-of-all-trades type of serial port
>> device. It has a built-in programmable execution engine that can be programmed
>> to operate as almost any serial bus (I2C, SPI, EasyScale, and others).
>>
>> This patch adds a driver for this controller device. The driver does not
>> expose a user-land interface. Protocol drivers built on top of this layer are
>> expected to remain in-kernel.
>
> I suspect the driver belongs with the mfd drivers not with drivers/misc ?
>
> otherwise it looks very nice.

Unlike MFDs, this device doesn't have cells with differing
functionality. Instead it has functionally identical ports that can
operate in a variety of modes. That said, does this still fit in with
other MFD drivers? If so, I don't see a problem with moving it there.

Thanks
Cyril.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/