Re: [PATCH] pca953x: pca953x driver fixes for x86 mrst

[Andrew Morton]

On Fri, 22 Oct 2010 13:47:47 +0100
Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:

> From: Alek Du <alek.du@xxxxxxxxx>
> 
> Our Moorestown platform has two max7315 chips which is covered by
> pca953x i2c gpio driver.
> 
> A while ago this driver got updated with nested irq thread support, and it
> broke the compatibity with "request_irq". For example, the gpio_keys.c
> driver can not work with this driver now. This patch fixes the issue by
> switching to generic_handle_irq.
> 
> Also fix the irq_base issue: irq_base == 0 is valid, and a "-1" value
> should mean invalid. IRQ 0 is not a valid IRQ, irq_base of 0 is valid.

This sounds like a regression fix.  Should it be backported into
-stable?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/