Re: [PATCH] lib/atomic64_test: do not build on non-atomic64 systems

[Andrew Morton]

On Fri, 22 Oct 2010 16:14:49 -0400
Mike Frysinger <vapier@xxxxxxxxxx> wrote:

> On Thu, Oct 21, 2010 at 19:24, Andrew Morton wrote:
> > On Thu, 21 Oct 2010 19:04:36 -0400 Mike Frysinger wrote:
> >> you can say "lazy" all you like. __i dont see the point in going that route.
> >
> > Try
> >
> > __ __ __ __grep HAVE arch/x86/Kconfig
> >
> > If all of those were instead to use some random #define which the
> > particular feature happened to define in some header file then we would
> > have a mess on our hands.
> 
> fun times.  new tact.
> 
> Luca: your new atomic64_t test build fails on all arches that lack
> atomic64_t.  please fix.

That's only part of the problem.  The following won't build also:

net/rds
kernel/perf_event.c
drivers/staging/octeon
drivers/infiniband/hw

with more to come.  These things should be made dependent upon
CONFIG_HAVE_ATOMIC64 in Kconfig.  (Can't use #ifdef ATOMIC64_INIT for this!)

Or, much better, we implement atomic64 on the offending architectures.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/