Re: [66/66] drivers/hwmon/coretemp.c: detect the thermal sensorsby CPUID

From: Greg KH
Date: Sat Oct 23 2010 - 12:06:37 EST


On Sat, Oct 23, 2010 at 11:27:32AM +0200, Jean Delvare wrote:
> On Fri, 22 Oct 2010 11:35:33 -0700, Greg KH wrote:
> > 2.6.32-stable review patch. If anyone has any objections, please let us know.
>
> Yes, I have an objection. This isn't a bug fix and thus doesn't belong
> to a stable kernel series. Furthermore, this change will let the
> coretemp driver bind to CPU devices it doesn't properly support. Proper
> support for recent CPUs would need commit
> a321cedb12904114e2ba5041a3673ca24deb09c9 (drivers/hwmon/coretemp.c: get
> TjMax value from MSR) which is way too large and intrusive for a stable
> series.
>
> So please drop this patch from the 2.6.32-stable queue.

Brad, I thought you got Jean's ack for this to be submitted for .32? If
not, why did you go around the maintainer for this?

Anyway, it's now removed, Jean, thanks for the review, and sorry for the
noise.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/