Re: [PATCH] x86, percpu: revert commit fe8e0c25

[Ingo Molnar]

* Tejun Heo <tj@xxxxxxxxxx> wrote:

> Commit fe8e0c25 (x86, 32-bit: Align percpu area and irq stacks to THREAD_SIZE) 
> aligned PERCPU section to THREAD_SIZE which can be larger than PAGE_SIZE, 
> introduced DEFINE_PER_CPU_MULTIPAGE_ALIGNED() and used it to make irq stacks 
> aligned to THREAD_SIZE on x86_32.
> 
> This won't work.  The PERCPU output section is used as the template to prepare the 
> percpu area and the actual percpu area is _alwasy_ aligned to PAGE_SIZE whether 
> the source area is aligned to larger size or not.

The problem is, this will reintroduce a nasty boot crash which commit fe8e0c25 
fixed. Do you say that fe8e0c25 didnt have the alignment effect?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/