Re: [PATCH 2/2] jump label: disable due to compiler bug
From: Steven Rostedt
Date: Fri Oct 29 2010 - 12:18:59 EST
On Fri, 2010-10-29 at 09:35 -0400, Mathieu Desnoyers wrote:
> * Steven Rostedt (rostedt@xxxxxxxxxxx) wrote:
> > Then in the code have:
> >
> > -#if defined(CC_HAVE_ASM_GOTO) && defined(CONFIG_HAVE_ARCH_JUMP_LABEL)
> > +#if defined(CC_HAVE_ASM_GOTO) && defined(CONFIG_HAVE_ARCH_JUMP_LABEL) \
>
> Technically, you could remove the dependency on
> "defined(CONFIG_HAVE_ARCH_JUMP_LABEL)", because it is now dealt with at
> the Kconfig level (CONFIG_JUMP_LABEL depends on it).
Yeah, I noticed that just after hitting send.
>
> > + && defined(JUMP_LABEL)
>
> this would be defined(CONFIG_JUMP_LABEL)
Yep, this too, but thanks for pointing it out.
>
> The rest looks fine,
Great, can I add your acked-by then?
-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/