Re: [PATCH v2] x86: kvm: fix information leak to userland

From: Jan Kiszka
Date: Sat Oct 30 2010 - 11:46:23 EST


Am 30.10.2010 17:31, Vasiliy Kulikov wrote:
> On Sat, Oct 30, 2010 at 16:34 +0200, Jan Kiszka wrote:
>> Am 30.10.2010 16:11, Vasiliy Kulikov wrote:
>>> Structure kvm_ppc_pvinfo is copied to userland with pad field
>>> unitialized. Structure kvm_clock_data is copied to userland with
>>> flags and pad fields unitialized. It leads to leaking of contents
>>> of kernel stack memory.
>>
>> This description only partially matches your patch, please fix.
>
> What do you mean? Two structures are copied with some fields with old
> stack values. Smth valuable else?

I mean you aren't touching ppc code in this patch, but you are fixing
more than just the kvm_clock interface.

Jan

Attachment: signature.asc
Description: OpenPGP digital signature