Re: [PATCH 02/39] arch/alpha: Update WARN uses
From: Matt Turner
Date: Sat Oct 30 2010 - 17:17:56 EST
On Sat, Oct 30, 2010 at 5:08 PM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> Coalesce long formats.
> Align arguments.
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
> arch/alpha/kernel/pci-sysfs.c | 14 ++++++--------
> 1 files changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c
> index b899e95..6f30ac3 100644
> --- a/arch/alpha/kernel/pci-sysfs.c
> +++ b/arch/alpha/kernel/pci-sysfs.c
> @@ -44,10 +44,9 @@ static int __pci_mmap_fits(struct pci_dev *pdev, int num,
>
> if (start < size && size - start >= nr)
> return 1;
> - WARN(1, "process \"%s\" tried to map%s 0x%08lx-0x%08lx on %s BAR %d "
> - "(size 0x%08lx)\n",
> - current->comm, sparse ? " sparse" : "", start, start + nr,
> - pci_name(pdev), num, size);
> + WARN(1, "process \"%s\" tried to map%s 0x%08lx-0x%08lx on %s BAR %d (size 0x%08lx)\n",
> + current->comm, sparse ? " sparse" : "", start, start + nr,
> + pci_name(pdev), num, size);
> return 0;
> }
>
> @@ -261,10 +260,9 @@ static int __legacy_mmap_fits(struct pci_controller *hose,
>
> if (start < size && size - start >= nr)
> return 1;
> - WARN(1, "process \"%s\" tried to map%s 0x%08lx-0x%08lx on hose %d "
> - "(size 0x%08lx)\n",
> - current->comm, sparse ? " sparse" : "", start, start + nr,
> - hose->index, size);
> + WARN(1, "process \"%s\" tried to map%s 0x%08lx-0x%08lx on hose %d (size 0x%08lx)\n",
> + current->comm, sparse ? " sparse" : "", start, start + nr,
> + hose->index, size);
> return 0;
> }
>
> --
> 1.7.3.1.g432b3.dirty
What's accomplished here? It looks like you joined two strings (which
were separated as to not overflow the 80-char limit) and spaced a
couple lines over.
I don't see how this makes anything clearer.
Matt
--
To unsubscribe from this list: send the line "unsubscribe linux-alpha" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html