Re: [PATCH/RFC] m68k/sun3: Kill pte_unmap() warnings

[Andreas Schwab]

Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> writes:

> Which one is preferable?
>
> -------------------------------------------------------------------------------
> Since commit 31c911329e048b715a1dfeaaf617be9430fd7f4e ("mm: check the argument
> of kunmap on architectures without highmem"), we get lots of warnings like
>
> arch/m68k/kernel/sys_m68k.c:508: warning: passing argument 1 of âkunmapâ from incompatible pointer type
>
> As m68k doesn't support highmem anyway, open code the calls to kmap() and
> kunmap() (the latter is a no-op) to kill the warnings.

I prefer this one, it matches all architectures without CONFIG_HIGHPTE.

Andreas.

-- 
Andreas Schwab, schwab@xxxxxxxxxxxxxx
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/