Re: [PATCH 10/16 v2] pramfs: XIP operations

From: James Hogan
Date: Sat Nov 06 2010 - 09:33:49 EST


Hi,

On Sat, Nov 06, 2010 at 09:59:27AM +0100, Marco Stornelli wrote:
> diff -Nurp linux-2.6.36-orig/fs/pramfs/xip.c linux-2.6.36/fs/pramfs/xip.c
> --- linux-2.6.36-orig/fs/pramfs/xip.c 1970-01-01 01:00:00.000000000 +0100
> +++ linux-2.6.36/fs/pramfs/xip.c 2010-09-14 18:49:52.000000000 +0200
<snip>
> +static int pram_find_and_alloc_blocks(struct inode *inode, sector_t iblock,
> + sector_t *data_block, int create)
> +{
> + int err = -EIO;
> + u64 block;
> +
> + mutex_lock(&PRAM_I(inode)->truncate_lock);

fs/pramfs/xip.c: In function âpram_find_and_alloc_blocksâ:
fs/pramfs/xip.c:27: error: âstruct pram_inode_vfsâ has no member named
âtruncate_lockâ
fs/pramfs/xip.c:52: error: âstruct pram_inode_vfsâ has no member named
âtruncate_lockâ

i guess that should be truncate_mutex.

> +
> + block = pram_find_data_block(inode, iblock);
> +
> + if (!block) {
> + if (!create) {
> + err = -ENODATA;
> + goto err;
> + }
> +
> + err = pram_alloc_blocks(inode, iblock, 1);
> + if (err)
> + goto err;
> +
> + block = pram_find_data_block(inode, iblock);
> + if (!block) {
> + err = -ENODATA;
> + goto err;
> + }
> + }
> +
> + *data_block = block;
> + err = 0;
> +
> + err:
> + mutex_unlock(&PRAM_I(inode)->truncate_lock);

same here

> + return err;
> +}

Cheers
James
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/