Re: [PATCH 02/16 v2] pramfs: super block operations

From: Marco Stornelli
Date: Mon Nov 08 2010 - 06:54:24 EST


2010/11/8 yidong zhang <zhangyd6@xxxxxxxxx>:
> hi Marco
>> +       retval = 0;
>> + out:
>> +       if (retval && sbi->virt_addr) {
>> +               iounmap(sbi->virt_addr);
>> +               release_mem_region(sbi->phys_addr, initsize);
>> +       }
>> +
>> +       return retval;
>> +}
>  Should add kfree(sbi) here in case of  failure?
>

Yes, thank you very much.

Marco
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/