Re: [DRAFT PATCH 2/3] perf: Implement Nehalem uncore pmu

[Andi Kleen]

Lin Ming <ming.m.lin@xxxxxxxxx> writes:

Looking at a an old patch.

> +
> +static void uncore_pmu_disable_events(void)
> +{
> +	struct uncore_cpu_hw_events *cpuc = &__get_cpu_var(uncore_cpu_hw_events);
> +	int node = numa_node_id();

Using numa_node_id() here implies this can't be used when NUMA is turned
off. Better use the package id.

-Andi

-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/