Re: [RFCv3 10/21] tcm: Add SPC-4 compliant Persistent Reservations(PR)

[Nicholas A. Bellinger]

On Mon, 2010-11-08 at 09:50 -0500, Christoph Hellwig wrote:
> Gcc on 32-bit x86 doesn't seem too happy about the stack usage here:
> 
> drivers/target/target_core_pr.c: In function '__core_scsi3_update_aptpl_buf':
> drivers/target/target_core_pr.c:1955: warning: the frame size of 1116 bytes is larger than 1024 bytes
> 

Hmmm, strange.  I am not seeing this on any of my 32-bit builds..  

Anyways, since __core_scsi3_update_aptpl_buf() is internally holding the
T10_RES(su_dev)->registration_lock while walking
T10_RES(su_dev)->registration_list to build the passed APTPL *buf, this
local scope tmp[1024] can be safetly converted to a
T10_RES(su_dev)->tmp_buf[] and drop the extra stack usage.

Thanks,

--nab

> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/