Re: Linux 2.6.37-rc1 (libipw remove_proc_entry warning)

[John W. Linville]

On Fri, Nov 05, 2010 at 04:38:14PM -0700, Linus Torvalds wrote:
> On Fri, Nov 5, 2010 at 4:06 PM, Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:
> > On 11/05/10 15:24, Linus Torvalds wrote:
> >>
> >> Totally UNTESTED patch attached. It may or may not compile. And maybe
> >> it doesn't catch all cases, but it should catch the obvious ones.
> >
> > That works for me.
> >
> > Tested-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> 
> Goodie. Pavel, John - feel free to add my sign-off on that patch. Make
> up a relevant commit message. Ok?

In the queue...

commit 269e2d77b82d92d8dad543a2375e74372e9d773e
Author: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date:   Mon Nov 8 16:27:12 2010 -0500

    libipw: fix proc entry removal
    
    This bug seems to be due to commit 27ae60f8f7aac ("ipw2x00: replace
    "ieee80211" with "libipw" where appropriate"), where Pavel did this:
    
    -       libipw_proc = proc_mkdir(DRV_NAME, init_net.proc_net);
    +       libipw_proc = proc_mkdir("ieee80211", init_net.proc_net);
    
    but then the cleanup was kept as
    
            remove_proc_entry(DRV_NAME, init_net.proc_net);
    
    in both places (both in the failure case and in the unload case). The
    error string is also total crap, and says
    
         "Unable to create " DRV_NAME " proc directory\n");
    
    Even though it doesn't actually create a proc directory named DRV_NAME at all.
    
    So that patch looks like total and utter crap to me. The commit message says
    
      "Keep /proc/net/ieee80211 under the original name to avoid breaking user
        interface."
    
    but the thing is, it really didn't fix anything but that one create
    thing. It needs to fix all the other cases too.
    
    Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
    Tested-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
    Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx>

Sorry for the delay -- I'm not a good traveler!
-- 
John W. Linville		Someday the world will need a hero, and you
linville@xxxxxxxxxxxxx			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/