Re: [PATCH 08/17][trivial] scsi: Remove unnecessary casts of voidptr returning alloc function return values

[Jesper Juhl]

On Mon, 8 Nov 2010, Joe Perches wrote:

> On Tue, 2010-11-09 at 00:09 +0100, Jesper Juhl wrote:
> > Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>
> > diff --git a/drivers/scsi/aic7xxx/aic7xxx_core.c b/drivers/scsi/aic7xxx/aic7xxx_core.c
> []
> > @@ -4780,7 +4780,7 @@ ahc_init_scbdata(struct ahc_softc *ahc)
> >  	SLIST_INIT(&scb_data->sg_maps);
> >  
> >  	/* Allocate SCB resources */
> > -	scb_data->scbarray = (struct scb *)kmalloc(sizeof(struct scb) * AHC_SCB_MAX_ALLOC, GFP_ATOMIC);
> > +	scb_data->scbarray = kmalloc(sizeof(struct scb) * AHC_SCB_MAX_ALLOC, GFP_ATOMIC);
> >  	if (scb_data->scbarray == NULL)
> >  		return (ENOMEM);
> >  	memset(scb_data->scbarray, 0, sizeof(struct scb) * AHC_SCB_MAX_ALLOC);
> 
> This would be better as:
> 
> 	scb_data->scbarray = kcalloc(AHC_SCB_MAX_ALLOC, sizeof(struct scb), GFP_ATOMIC)
> 
> without the memset.
> 

True, I did notice that, and I guess I could have done that as part of 
this patch series, just as there are lots of other minor improvements I 
was tempted to do. But, I wanted to keep the entire patch series to a 
single specific topic, then once they are merged (hopefully) I can follow 
up with other cleanups.

-- 
Jesper Juhl <jj@xxxxxxxxxxxxx>             http://www.chaosbits.net/
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/