Re: [PATCH] hwmon: (ad7414) Return proper error code forad7414_probe()

[Sean MacLennan]

On Mon, 8 Nov 2010 20:40:34 -0500
"Axel Lin" <axel.lin@xxxxxxxxx> wrote:

> [PATCH] hwmon: (ad7414) Return proper error code for ad7414_probe()
> 
> Return proper error if i2c_check_functionality reports
> the adapter does not support the capability we need.
> 
> Also remove unneeded initialization for err variable.
> 
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>

Acked-by: Sean MacLennan <smaclennan@xxxxxxxxxxxx>

> ---
>  drivers/hwmon/ad7414.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/ad7414.c b/drivers/hwmon/ad7414.c
> index 1e4c21f..86d822a 100644
> --- a/drivers/hwmon/ad7414.c
> +++ b/drivers/hwmon/ad7414.c
> @@ -178,11 +178,13 @@ static int ad7414_probe(struct i2c_client
> *client, {
>         struct ad7414_data *data;
>         int conf;
> -       int err = 0;
> +       int err;

I wouldn't mind if this was "int conf, err;", but I don't mind the way
it is.

Cheers,
   Sean
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/