Re: [PATCH] hwmon: (gpio-fan) Fix fan_ctrl_init error path

[Simon Guinot]

On Tue, Nov 09, 2010 at 04:22:02PM +0800, Axel Lin wrote:
> 2010/11/9 Jean Delvare <khali@xxxxxxxxxxxx>:
> > On Tue, 09 Nov 2010 13:18:39 +0800, Axel Lin wrote:
> >> Remove sysfs entries before return -ENODEV.
> >>
> >> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
> >> ---
> >> Âdrivers/hwmon/gpio-fan.c | Â Â4 +++-
> >> Â1 files changed, 3 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/drivers/hwmon/gpio-fan.c b/drivers/hwmon/gpio-fan.c
> >> index aa701a1..d2e66b4 100644
> >> --- a/drivers/hwmon/gpio-fan.c
> >> +++ b/drivers/hwmon/gpio-fan.c
> >> @@ -388,11 +388,13 @@ static int fan_ctrl_init(struct gpio_fan_data *fan_data,
> >> Â Â Â fan_data->speed_index = get_fan_speed_index(fan_data);
> >> Â Â Â if (fan_data->speed_index < 0) {
> >> Â Â Â Â Â Â Â err = -ENODEV;
> >> - Â Â Â Â Â Â goto err_free_gpio;
> >> + Â Â Â Â Â Â goto err_remove_sysfs;
> >> Â Â Â }
> >>
> >> Â Â Â return 0;
> >>
> >> +err_remove_sysfs:
> >> + Â Â sysfs_remove_group(&pdev->dev.kobj, &gpio_fan_ctrl_group);
> >> Âerr_free_gpio:
> >> Â Â Â for (i = i - 1; i >= 0; i--)
> >> Â Â Â Â Â Â Â gpio_free(ctrl[i]);
> >
> > Oh, and while you're here, fan_alarm_init() needs some love as well.
> > There's a "return 0" in the middle which clearly can't be correct.
> I think this part is correct. see the comment:
>         /*
>          * If the alarm GPIO don't support interrupts, just leave
>          * without initializing the fail notification support.
>          */
> 

Yes, GPIO interrupts could not be supported. That's not an error case.

Simon

Attachment: signature.asc
Description: Digital signature