Re: [PATCH 6/6 v3] ARM: Add support for the display controllers inVT8500 and WM8505

[Russell King - ARM Linux]

On Tue, Nov 09, 2010 at 07:51:45PM +0900, Paul Mundt wrote:
> On Tue, Nov 09, 2010 at 10:33:12AM +0000, Russell King - ARM Linux wrote:
> > On Tue, Nov 09, 2010 at 05:43:16AM +0900, Paul Mundt wrote:
> > > > diff --git a/drivers/video/vt8500lcdfb.c b/drivers/video/vt8500lcdfb.c
> > > > new file mode 100644
> > > > index 0000000..640d8a3
> > > > --- /dev/null
> > > > +++ b/drivers/video/vt8500lcdfb.c
> > > > +#include <asm/irq.h>
> > > > +
> > > linux/irq.h is preferred here.
> > 
> > I assume you've read the comment at the top of linux/irq.h ?
> 
> I had forgotten about that. This comment predates git, so I'm unaware of
> what the context is, could you elaborate on it?

It's from a time when we didn't have generic irq (and as I understand,
generic irq is still optional.)

When you didn't have generic irq support for an arch, having drivers
include linux/irq.h resulted in build errors, caused by nothing more
than "use linux/foo.h rather than asm/foo.h" - as those architectures
won't provide an asm/hw_irq.h.

It looks to me like the only arch in the kernel which doesn't support
generic irq is sh.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/