Re: [patch 1/6] fs: icache RCU free inodes

[Andi Kleen]

Nick Piggin <npiggin@xxxxxxxxx> writes:

> So here is the inode RCU code. It's obviously not worth doing until the
> actual rcu-walk path walking is in, but I'd like to get opinions on it.
> It would be nice to merge it in Al's tree at some point, though.

I read the patch. It was quite monotonous (I guess that's a good thing)
But it wasn't clear to me why you added the INIT_LIST_HEAD()s
everywhere. Is this for stopping parallel walkers?

Ok there's a comment in the doc: "VFS expects it to be initialized"
Is that really true today?  I don't think the old code does that.

Other than that it seems straight forward.

Reviewed-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

-Andi

-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/