Re: [PATCH 1/1] virt: ack_flush() function removed for lack of apparentuse 2.6.37-rc1

From: Avi Kivity
Date: Tue Nov 09 2010 - 09:33:02 EST


On 11/06/2010 07:01 AM, André Luis Pereira dos Santos - BSRSoft wrote:
Hello

Ack_flush function () is not used anywhere in the code and apparently has no function currently defined.

Unless there are plans to use it in the future, I took it out via this patch code for readability.



Signed-off-by: Andre Luis Pereira dos Santos<andre@xxxxxxxxxxxxxx>
---
Signed-off-by: Andre Luis Pereira dos Santos<andre@xxxxxxxxxxxxxx>
--- linux-2.6.37-rc1/virt/kvm/kvm_main.c 2010-11-01 09:54:12.000000000 -0200
+++ linux-2.6.37-rc1-patched/virt/kvm/kvm_main.c 2010-11-06 02:43:56.000000000 -0200
@@ -132,9 +132,6 @@ void vcpu_put(struct kvm_vcpu *vcpu)
mutex_unlock(&vcpu->mutex);
}

-static void ack_flush(void *_completed)
-{
-}


It is in use:
upstream:virt/kvm/kvm_main.c:static void ack_flush(void *_completed)
upstream:virt/kvm/kvm_main.c: smp_call_function_many(cpu_online_mask, ack_flush, NULL, 1);
upstream:virt/kvm/kvm_main.c: smp_call_function_many(cpus, ack_flush, NULL, 1);


--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/