Re: [PATCH] ipc: explicitly clear stack memory in user structs

[Kees Cook]

On Tue, Nov 09, 2010 at 05:03:30PM -0800, Joe Perches wrote:
> On Tue, 2010-11-09 at 16:54 -0800, Linus Torvalds wrote:
> > On Tue, Nov 9, 2010 at 3:48 PM, Kees Cook <kees.cook@xxxxxxxxxxxxx> wrote:
> > >> I don't quite see where you got the particular collection of people from.
> > > I used scripts/get_maintainer.pl
> > Hmm. I get totally different results. You had
> >   linux-kernel@xxxxxxxxxxxxxxx
> >   Al Viro <viro@xxxxxxxxxxxxxxxxxx>,
> >   Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>,
> >   Jiri Slaby <jslaby@xxxxxxx>,
> >   "David S. Miller" <davem@xxxxxxxxxxxxx>
> > and I get
> >   Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> >   Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> >   Helge Deller <deller@xxxxxx>
> >   David Howells <dhowells@xxxxxxxxxx>
> >   Hugh Dickins <hughd@xxxxxxxxxx>
> >   linux-kernel@xxxxxxxxxxxxxxx
> > so there is something odd going on there.
> 
> I'd like to know as well.

Well, let's see what happens. If I rewind the tree to roughly
542181d3769d001c59cd17573dd4381e87d215f2 taking a wild guess at where my
tree was when I send the patch, and run it, here's what I get:

$ ./scripts/get_maintainer.pl 0001-ipc-initialize-structure-memory-to-zero-in-shm.patch
Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Jiri Slaby <jslaby@xxxxxxx>
"Serge E. Hallyn" <serue@xxxxxxxxxx>
"David S. Miller" <davem@xxxxxxxxxxxxx>
linux-kernel@xxxxxxxxxxxxxxx

And since I know Serge's address isn't at ibm any more, I dropped it from
Cc, assuming he didn't care about ipc structure fixups.

If I fast-forward to today and run it, I get the same output you do.

-Kees

-- 
Kees Cook
Ubuntu Security Team
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/