Re: [PATCH 6/6] ce4100: Add support for CE4100 EHCI IP block to EHCIdriver

[Alan Stern]

On Tue, 9 Nov 2010, Dirk Brandewie wrote:

> In a previous patch in this series GregKH asked that the PCI ID not be added 
> to pci_ids.h for ID's that are only used by a single file.  
> Here is an updated version of the EHCI controller patch.
> 
> Subject: [PATCH] ce4100: Add support for CE4100 EHCI IP block to EHCI driver
> 
> This patch adds support for the EHCI IP block present on the Intel
> CE4100.
> 
> Signed-off-by: Dirk Brandewie <dirk.brandewie@xxxxxxxxx>
> CC: linux-usb@xxxxxxxxxxxxxxx
> CC: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/usb/host/ehci-pci.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
> index a1e8d27..da2b196 100644
> --- a/drivers/usb/host/ehci-pci.c
> +++ b/drivers/usb/host/ehci-pci.c
> @@ -124,6 +124,10 @@ static int ehci_pci_setup(struct usb_hcd *hcd)
>  			ehci_info(ehci, "disable lpm for langwell/penwell\n");
>  			ehci->has_lpm = 0;
>  		}
> +		if (pdev->device == 0x2e70) {
> +			hcd->has_tt = 1;
> +			tdi_reset(ehci);
> +		}

I think Greg meant that it's okay to use a symbolic constant for the
PCI ID (it helps tell people what hardware is being handled).  Just
don't add that constant to the pci_ids.h file.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/