RE: [PATCH] staging: lis331dlh: add lis331dlh driver

[Carmine IASCONE]

Hi Greg, Hi JS,
Matteo and I have started to develop linux device drivers for our STMicroelectronics sensors about one year ago. Our main target is the Android platform (mobile phone or tablet pc), and for this reason the drivers are thought to be used on I2C bus. The drivers are enough stable, we have several customers that are using them, and also with the advice of these customers, we would like to make available them for all the linux community, merging them in the kernel upstream to be used in all linux supported platforms.
The drivers have had a initial review by Alan Cox, that gives us some very precious advices to improve the style and robustness of the drivers. 
We are newbies in patch generation and submission: we have followed the instructions in the Greg's video on you tube to create this first patch, so sorry if there is something that we missed. We thought to put the driver in staging directory, because before merging them in the main tree we would like to have a general revision, and also because in this first release we haven't managed the device interrupts yet. At the end the right position for these drivers could be drivers/input/misc.
How do we proceed now? Do we need to generate a new patch adding the TODO file? Please advice.

Our email references are:

Carmine Iascone <carmine.iascone@xxxxxx>
Matteo Dameno <matteo.dameno@xxxxxx>

Best regards,
Carmine


-----Original Message-----
From: Greg KH [mailto:gregkh@xxxxxxx] 
Sent: Tuesday, November 09, 2010 6:36 PM
To: mems applications
Cc: Carmine IASCONE; Matteo DAMENO; devel@xxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [PATCH] staging: lis331dlh: add lis331dlh driver

On Tue, Nov 09, 2010 at 06:25:27PM +0100, mems applications wrote:
> Add STMicroelectronics LIS331DLH digital accelerometer device driver
> 
> From: Carmine Iascone <carmine.iascone@xxxxxx>
> ---
>  drivers/staging/Kconfig               |    2 +
>  drivers/staging/Makefile              |    1 +
>  drivers/staging/lis331dlh/Kconfig     |    7 +
>  drivers/staging/lis331dlh/Makefile    |    1 +
>  drivers/staging/lis331dlh/lis331dlh.c |  836 +++++++++++++++++++++++++++++++++
>  drivers/staging/lis331dlh/lis331dlh.h |   83 ++++
>  6 files changed, 930 insertions(+), 0 deletions(-)

Why is this a staging driver?  What is keeping it from being merged to
the main portion of the kernel tree?

Can you please provide a TODO file that lists the things left to do on
it, and provide some email addresses to contact you for it?  Look at the
other TODO files in drivers/staging/*/TODO for examples.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/