Re: [PATCH] Fix implicit declaration of 'in_irq' in linux/highmem.h

[Peter Zijlstra]

On Wed, 2010-11-10 at 11:31 +0000, Catalin Marinas wrote:
> Commit 3e4d3af introduced the kmap_atomic_idx_push() function which
> warns on in_irq() with CONFIG_DEBUG_HIGHMEM enabled. This patch includes
> linux/hardirq.h for the in_irq definition.

Ah, indeed. The whole KS/LPC thing made me forget about this issue.
Somehow it only triggered on ARM.

> Signed-off-by: Catalin Marinas <catalin.marinas@xxxxxxx>

Acked-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>

> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
>  include/linux/highmem.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/highmem.h b/include/linux/highmem.h
> index e913819..b676c58 100644
> --- a/include/linux/highmem.h
> +++ b/include/linux/highmem.h
> @@ -5,6 +5,7 @@
>  #include <linux/kernel.h>
>  #include <linux/mm.h>
>  #include <linux/uaccess.h>
> +#include <linux/hardirq.h>
>  
>  #include <asm/cacheflush.h>
>  
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/