Re: [PATCH 2/2 v2] Unify rest of FAT messages.

[Alexey Fisher]

Am Mittwoch, den 10.11.2010, 22:53 +0900 schrieb OGAWA Hirofumi:
> Alexey Fisher <bug-track@xxxxxxxxxxxxxxxxx> writes:
> 
> > Am Mittwoch, den 10.11.2010, 20:40 +0900 schrieb OGAWA Hirofumi:
> >> Alexey Fisher <bug-track@xxxxxxxxxxxxxxxxx> writes:
> >> 
> >> > Here is how it looks like after patch.
> >> 
> >> This is going to unify the all FSes (e.g. fat_msg() uses fs_msg("FAT", ...))?
> >> If so, I think it's welcome. If not, umm, it looks like good but...
> >
> > Yea, i thought about it. It will be better to have some kernel wide
> > fs_msg(). But before doing this i think one more step should be done -
> > some notification interface for userspace. 
> > If we get some fs errors userspace app should be notified so user too.
> >
> > I work currently on one case, user lost all data on FAT drive. First
> > error messages was logged for some weeks, and only now some big data
> > lost. There war no errors from GUI.
> 
> It clealy can happen on all FSes, not only FAT. And I don't want to push
> it (notification stuff) from FAT tree. (need the review from other guys).

I do not blame FAT. It was just one example/usecase.

> IMHO, it should be kernel wide (or subsystem wide) notification system
> even if you target is FAT-fs only.  (yeah, it's hard to push to
> linus-tree than one FS though).

Sound complicated. I will not get time for this, right now. Any way, at
least if this patch set go upstream it will help investigate some FS
related issues. For my work (Computer Forensic) it will be really
helpful.

Regards,
Alexey


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/