Re: [PATCH v3] msm: smd: Reduce driver log chatter

[Brian Swetland]

At this point, I think we could just drop the printk()s on the init
functions.  They date back from when we first brought up the driver
and I'm not sure they're of much value at all any more.

Brian

On Wed, Nov 10, 2010 at 10:24 AM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Wed, 2010-11-10 at 09:59 -0800, David Brown wrote:
>> Âarch/arm/mach-msm/smd.c | Â 18 ++++++++++--------
>
> Hi again David. ÂMore trivia. Ignore at your pleasure.
>
>> Â1 files changed, 10 insertions(+), 8 deletions(-)
>> diff --git a/arch/arm/mach-msm/smd.c b/arch/arm/mach-msm/smd.c
>
> A moderately common kernel style uses macros like:
>
> #define FUNC_ENTER() Â Âpr_debug("--> %s\n", __func__);
> #define FUNC_EXIT() Â Â pr_debug("<-- %s\n", __func__);
> or
> #define FUNC_ENTER() Â Âpr_debug("Enter %s\n", __func__);
> #define FUNC_EXIT() Â Â pr_debug("Exit Â%s\n", __func__);
>
> The macro names vary.
> I've seen enter, _enter, kenter, func_enter, etc.
>
>> @@ -939,7 +941,7 @@ int smsm_set_sleep_duration(uint32_t delay)
>> Âint smd_core_init(void)
>> Â{
>> Â Â Â int r;
>> - Â Â pr_info("smd_core_init()\n");
>> + Â Â pr_debug("smd_core_init()\n");
>
> Â Â Â ÂFUNC_ENTER();
>
>> @@ -992,14 +994,14 @@ int smd_core_init(void)
>> Â Â Â smsm_change_state(SMSM_STATE_APPS_DEM, ~0, 0);
>> Â#endif
>>
>> - Â Â pr_info("smd_core_init() done\n");
>> + Â Â pr_debug("smd_core_init() done\n");
>
> Â Â Â ÂFUNC_EXIT();
>
>> Âstatic int __devinit msm_smd_probe(struct platform_device *pdev)
>> Â{
>> - Â Â pr_info("smd_init()\n");
>> + Â Â pr_debug("smd_init()\n");
>
> wrong function name? FUNC_ENTER();
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/